Chaos Corona Forum

Chaos Corona for 3ds Max => [Max] Bug Reporting => [Max] Resolved Bugs => Topic started by: alexyork on 2016-06-06, 15:49:09

Title: Removing Env Map while IR is on = crash
Post by: alexyork on 2016-06-06, 15:49:09
Not entirely unexpected behaviour I guess, but easily done...

Simply run IR and then remove the environment map from E&E window = crash.

Cheers,
Title: Re: Removing Env Map while IR is on = crash
Post by: maru on 2016-06-06, 17:33:46
Definitely shouldn't happen.
Definitely not happening for me.

...maybe that env map was VrayHDRI? :>
Title: Re: Removing Env Map while IR is on = crash
Post by: alexyork on 2016-06-06, 17:38:04
Definitely shouldn't happen.
Definitely not happening for me.

...maybe that env map was VrayHDRI? :>

Nope :) As per strict instructions we're using CoronaBitmap for HDR stuff (although it's painful... - rotations don't seem to work at all...). We're not having a lot of success working with it to be honest. Hope a dedicated CoronaHDRILoader is released... :)
Title: Re: Removing Env Map while IR is on = crash
Post by: Ondra on 2016-06-06, 18:05:09
CoronaBitmap IS the HDR loader, there wont be another dedicated shader. But we are open to tweaking its UI. Although I have a feeling people just cannot accept that HDRIs are bitmaps too ;).

as for the crash, if you can reproduce it, could you post a minidump?
Title: Re: Removing Env Map while IR is on = crash
Post by: alexyork on 2016-06-07, 10:22:42
CoronaBitmap IS the HDR loader, there wont be another dedicated shader. But we are open to tweaking its UI. Although I have a feeling people just cannot accept that HDRIs are bitmaps too ;).

as for the crash, if you can reproduce it, could you post a minidump?

That's cool, it's really the rotation control and gamma controls that should be exposed in the shader that would do the trick. I was not able to get any kind of rotation to work at all yesterday while trying this. I will test again today and see if I can reproduce either/both issues.
Title: Re: Removing Env Map while IR is on = crash
Post by: maru on 2016-06-08, 15:58:47
Here are some examples:

Rotation:
(https://forum.corona-renderer.com/index.php?action=dlattach;topic=12212.0;attach=47958;image)


Intensity:
(https://forum.corona-renderer.com/index.php?action=dlattach;topic=12212.0;attach=47960;image)


Gamma method 1 - in the loader - note: >1 will make the image "darker".
(https://forum.corona-renderer.com/index.php?action=dlattach;topic=12212.0;attach=47962;image)


Gamma method 2 - in color correction node - note: >1 will make the image "brighter".
(https://forum.corona-renderer.com/index.php?action=dlattach;topic=12212.0;attach=47964;image)

I can understand that gamma can be sometimes used and it would be handy to have this setting directly in the CBitmap ui.
Title: Re: Removing Env Map while IR is on = crash
Post by: alexyork on 2016-06-08, 18:13:06
Hey Maru thanks for these.

I've not had time to test this over the last couple of days. Crazy busy.

The gamma thing - yes - it's really, really useful. It's a great way to get more contrast and "vibrancy" out of the HDR for a shot. We use it literally every time, even if we're just shifting it around to 0.75 or 0.85 or so.

Will get back to you here once I've had a moment to bug test this rotation issue.

Cheers,
Title: Re: Removing Env Map while IR is on = crash
Post by: alexyork on 2016-06-08, 18:26:53
Ok so it seems that basically the U Offset goes from infinitely small value to infinitely large value in the spinner/box but in reality 0-degrees to 360-degrees is mapped to 0-1, which explains why I wasn't getting any feedback in the render... I was using values like 45 and 90 and 270 etc. whereas we need to use a value of 0.25 for 90 degrees, 0.5 for 180 degrees and so on, which is not user-friendly :)

So the first thing I would do would be to have a dedicated section in the CoronaBitmap called something like SphMapRotation mapped from 0-360. This would make it 100% clear how it works.

I would then have a simple Gamma control and you're done. I don't think there's anything else that would be needed that isn't already exposed in the shader.

By the way, maybe it's just me but HDR/EXR seems really really slow to load into the CoronaBitmap and in the material slot, and then to update in the IR viewport. The first time you start the IR, the HDR loads almost instantly and renders fine. But then if you change the offset, it seems to take a long while to recalc before it renders again.

Just my feedback.

EDIT: I can't seem to reproduce my own crash by removing the HDR from env slot. I guess it might have been an isolated thing.
Title: Re: Removing Env Map while IR is on = crash
Post by: Ondra on 2016-07-13, 11:16:51
ok, moving to resolved as it cannot be reproduced, next time it happens please send us the minidump ;)