Chaos Corona Forum

Official Stuff => News => Topic started by: Ondra on 2014-02-12, 19:51:17

Title: Improved light sampling
Post by: Ondra on 2014-02-12, 19:51:17
This should address most of the problems with persistent direct light noise:

(http://i.imgur.com/4nTg5G1.png)

It will be available in Alpha v6, which will be out shortly.

There will still be scenes where the result won't be as good, I will continue improving the sampler in the future to bring the same improvement to them.

edit: Less synthetic example:
(http://i.imgur.com/DCSHcDT.gif)

Still not entirely a real problematic scene. I am hoping somebody will try it in daily builds once I do new build
Title: Re: Improved light sampling
Post by: Ludvik Koutny on 2014-02-12, 19:54:51
It should mostly help with these kind of scenarios: http://forum.corona-renderer.com/index.php/topic,316.msg18617.html#msg18617

In general, scenarios where CoronaLights are combined with CoronaLightMTL geometry emitters.
Title: Re: Improved light sampling
Post by: racoonart on 2014-02-12, 19:57:50
Holy... That looks awesome. So which kind of lightsources will be working better? Only "mesh" lights or all kind of light sources (including portals)?
[Edit] Ok, question is already answered

(https://d24w6bsrhbeh9d.cloudfront.net/photo/aAYGVeL_460sa_v1.gif)
Title: Re: Improved light sampling
Post by: Ludvik Koutny on 2014-02-12, 20:04:27
Portals in Corona aren't really a light sources, they just tell renderer which direction should be sampled more.

Simplified explanation:
It will help in situation where mesh light steal sampling from object lights. In older build, if you made CoronaLight sphere and Sphere primitive with 64 polygons and LightMTL on it, then Sphere was considered to be 64 lights. So then, when lighting was sampled, there was considered to be 65 lights in scene, and CoronaLight sphere had equal importance as the remaining 64 of those polygons.

After this fix, polygons are not separate lights anymore, but grouped by the source objects. So one teapot is just one light, three teapots are three lights, and if you attach these three teapots together, they will be considered one light.
Title: Re: Improved light sampling
Post by: bilamofo on 2014-02-12, 20:27:57
If we are gonna express ourselves this way, then this was me against my lcd monitor:

(http://31.media.tumblr.com/tumblr_lzbhs3w0A51rn95k2o1_400.gif)

kudos!
Title: Re: Improved light sampling
Post by: maru on 2014-02-12, 20:28:33
OH LORD
Title: Re: Improved light sampling
Post by: Juraj on 2014-02-12, 20:29:12
(http://www.terminally-incoherent.com/blog/wp-content/uploads/2012/08/areyouawizard.png)

Actually, very nice update !
Title: Re: Improved light sampling
Post by: Tanakov on 2014-02-12, 20:36:03
Its ... so .. beatiful... I i ... wow.
Title: Re: Improved light sampling
Post by: Polymax on 2014-02-12, 21:22:22
really very good news. Thank a lot!
Title: Re: Improved light sampling
Post by: Stan_But on 2014-02-12, 21:32:36
sorry for so plagiarism.)) But...
(https://d24w6bsrhbeh9d.cloudfront.net/photo/aAYGVeL_460sa_v1.gif)(https://d24w6bsrhbeh9d.cloudfront.net/photo/aAYGVeL_460sa_v1.gif)(https://d24w6bsrhbeh9d.cloudfront.net/photo/aAYGVeL_460sa_v1.gif)
Title: Re: Improved light sampling
Post by: romullus on 2014-02-12, 21:35:16
It will be available in Alpha v6, which will be out shortly.

I've registered at forum two months ago, and that statment was one of the first things i've read. Waiting is almost unbearable now :]

Jokes aside, improvements looks impressive, but i'm curious to see how it'll prove itself in really complex scenario.
Title: Re: Improved light sampling
Post by: Ondra on 2014-02-12, 21:46:17
I've registered at forum two months ago, and that statment was one of the first things i've read. Waiting is almost unbearable now :]

Sorry, I was sick, and I needed to help friends with another project.
Title: Re: Improved light sampling
Post by: michaltimko on 2014-02-12, 21:49:27
I've registered at forum two months ago, and that statment was one of the first things i've read. Waiting is almost unbearable now :]

Sorry, I was sick, and I needed to help friends with another project.

Project : unlocking guns in bf4 :D
Title: Re: Improved light sampling
Post by: Ondra on 2014-02-12, 21:52:08
Project : unlocking guns in bf4 :D

Writing a siggraph paper.

I decided not to play BF4 on weekdays until A6 RC1 is out
Title: Re: Improved light sampling
Post by: Chakib on 2014-02-12, 22:07:27
(http://lh4.googleusercontent.com/-_ves7BADeYM/UOxw4mvNr2I/AAAAAAAAACk/dpfaUOJfcMU/s288/grumpy-cat-christmas-christmas-tree-on-fire-grumpy-cat-is-happy.jpg)
Title: Re: Improved light sampling
Post by: Marciortiz on 2014-02-12, 23:54:33
Can't wait for Alpha V6 here, from the bits that I could pick here and there I can see a massive update coming.


But I got a question if I may, is there any idea when the commercial version will be released? If we can dr with Corona + those few improvements already mentioned, I am very intend to present Corona as a new option to use at work.
Title: Re: Improved light sampling
Post by: orsobruno on 2014-02-13, 00:33:38
we have alredy made the switch to corona, and we don't regret! actually we found the "migrate" option very simple, especially the material part.....the materials editor in corona it's just amazing, and even complex material become easy, when you see the results instantly in the "material ball"!!

and with this update, it will definetly make us desire the A6 more and more :)

Thank you very much Ondra for this software :)
Title: Re: Improved light sampling
Post by: artmaknev on 2014-02-13, 07:10:51
Nice update, although I am really looking forward to distributed rendering availability!
Title: Re: Improved light sampling
Post by: Alessandro on 2014-02-13, 10:39:19
A quick test with an old scene, 4 passes, lighted just with lights filaments.
Title: Re: Improved light sampling
Post by: Levian on 2014-02-13, 11:52:01
even one person can change the world!
thank you for your work!
Title: Re: Improved light sampling
Post by: Utroll on 2014-02-13, 16:02:15
I decided not to xxxxxxx on weekdays until A6 RC1 is out
That's the kind of sentence you won't be happy to see quoted when you'll be selling a product :D

Nice improvement, as always.
Title: Re: Improved light sampling
Post by: Zzaba on 2014-02-14, 20:02:40
Corona is fantastically renderer! I love it ^)
Title: Re: Improved light sampling
Post by: magicbox on 2014-02-15, 08:50:14
Good update are looking forward to
Title: Re: Improved light sampling
Post by: Cherkes888 on 2014-02-17, 17:04:53
Wow! Mega Cool ) You is a magic man)
Title: Re: Improved light sampling
Post by: picfad on 2014-02-21, 18:15:36
Good news! Waiting for new release)
Title: Re: Improved light sampling
Post by: longhard on 2014-02-22, 03:24:54
Good news! Waiting for new release  Thank you very much!!
Title: Re: Improved light sampling
Post by: juang3d on 2014-02-23, 16:37:36
I decided not to play BF4 on weekdays until A6 RC1 is out

Let me say... I'm going to right now XD

Cheers
Title: Re: Improved light sampling
Post by: fobus on 2014-03-11, 14:54:03
Just tested light solvers. As Ondra says we it is good to keep light groups under 250 pcs. In my example we see that with "combined" light solver we can't get noise free lights (in accepted time). But with "Object-based" solver it is possible if we under 250 pcs of light groups. To make this groups we need to collapse object lights into one object (as I understood). But as we see with collapsed lights in building we're have very strange light solution. Looks like some of the lights are not sampled well. So if we have much lights that can't be collapsed (moving for example, or lights in buildings like in my example, or smth else) we can't get benefit from this solver. Hmm... It was one of the main reasons for this feature I think...
Title: Re: Improved light sampling
Post by: Ludvik Koutny on 2014-03-11, 15:31:41
Seems like second picture may actually show solution to render the scene in acceptable time. In general, you should cluster together lights that are close together and illuminate same surfaces. So for example try to attach lights that are in same rooms :) And if there is more rooms with lights than what fits in 250 limit, then try to attach a bunch pairs of neighbouring close rooms together in distant background areas :)
Title: Re: Improved light sampling
Post by: fobus on 2014-03-11, 15:35:37
Second picture has downside on second frame (attached image). To geet 250 groups I had to collapse all oter lights in buildings. So other buildings looks like attached... In animation it is unacceptable.
Title: Re: Improved light sampling
Post by: Ludvik Koutny on 2014-03-11, 15:37:34
Could you count how many separate rooms with lights in them is in the entire scene? And then also how many other (exterior lights is there).

The point is, i would like to know how many light groups would this scene require in total. So amount of separate rooms with lights + amount of exterior lights.
Title: Re: Improved light sampling
Post by: fobus on 2014-03-11, 15:57:22
Could you count how many separate rooms with lights in them is in the entire scene? And then also how many other (exterior lights is there).

Three main buildings has ~200 rooms interested to us (other we can't see). There is a ~30 lights on streets. And countless number of rooms in nearby buildings, cars and so on. And it is one of the simplest exterior scenes.
Title: Re: Improved light sampling
Post by: Ludvik Koutny on 2014-03-11, 16:01:31
Ok, so my first suggestion would be simply to hide all the lights that are not visible for given shot.

If that is not possible. Then i would place real emitters only in buildings of interest, and attach them by rooms they are into, and for background buildings, i would use self illuminated CoronaMTL instead of lights... :) I am not sure it will perform well, but i would give it a try.

The reason i asked about exact number is that the limit of 250 lights after which light solver is switched can actually be changed, but it comes at some costs, so i first need a good example case to justify asking him to increase the limit.
Title: Re: Improved light sampling
Post by: fobus on 2014-03-11, 16:09:55
Hmm... As I understood from Your words light solver switching to combined automaticaly after reaching 250 groups? It's interesting. May be it will be usefull to make choice to increase or decrease this limit?

As for this particular scene I don't think it will be good to use self-illuminated material in rooms of nearby buildings because it may be difficult to light interiors of their rooms to be natural. And of course we can't turn them off because we neeв them in animation all together as our camera moves across the street. But I'll try to do like You said.

Update:
Long scene parsing is huge slowdown for tests ;(
Title: Re: Improved light sampling
Post by: Ludvik Koutny on 2014-03-11, 16:16:28
Not to combined, but it will just disable smart sampling of lights. I would try self-illum...  it may be a bit more noisy then real emission, but should not look less natural. As i already said, there is no difference between emission and self illumination aside from fact that self illum is not sampled explicitly, but only randomly by GI. So it will be probably slower, but not nearly as slow as real emitters with too much attaching together or when smart light sampling gets disabled.
Title: Re: Improved light sampling
Post by: Ondra on 2014-03-11, 16:25:45
can you upload me the entire scene so I can find out what is causing the long parsing? (if it is the one you uploaded before I already deleted that)
Title: Re: Improved light sampling
Post by: fobus on 2014-03-11, 16:34:35
can you upload me the entire scene so I can find out what is causing the long parsing? (if it is the one you uploaded before I already deleted that)

I can only upload "Mandrika" scene. I'll send You a link to PM.

to Rawalanche: it's looks like Your way to solve this scene works. From the first tests it is near to what we need.
Title: Re: Improved light sampling
Post by: fobus on 2014-03-12, 10:30:38
Finaly this scene solved :)

Fast render. Great result.
Viva la Corona!
Title: Re: Improved light sampling
Post by: Ludvik Koutny on 2014-03-12, 10:57:10
Awesome :)
Title: Re: Improved light sampling
Post by: arqrenderz on 2014-03-12, 13:34:38
So, whats the "final" solution for this kind of projects Fobus?
Title: Re: Improved light sampling
Post by: fobus on 2014-03-12, 13:41:50
So, whats the "final" solution for this kind of projects Fobus?

place real emitters only in buildings of interest, and attach them by rooms they are into, and for background buildings, i would use self illuminated CoronaMTL instead of lights... :)
Title: Re: Improved light sampling
Post by: rafpug on 2014-03-12, 22:07:56
Hello Fobus

Very Good!
...and always compliments to the Staff.
Title: Re: Improved light sampling
Post by: 3dgraphics on 2014-03-14, 10:24:28
can you fobus explain a bit how u got this project so clean!
Title: Re: Improved light sampling
Post by: fobus on 2014-03-14, 11:48:59
can you fobus explain a bit how u got this project so clean!

I just collapsed all the emitters by rooms. And placed in surround buildings self-illuminated lights with no emission. All of the lights are geometry with material applied.
Title: Re: Improved light sampling
Post by: 3dgraphics on 2014-03-14, 15:53:54
thanks!!!